Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Polyline): safegurad _setPositionDimensions #7850

Merged
merged 1 commit into from
Apr 1, 2022
Merged

fix(Polyline): safegurad _setPositionDimensions #7850

merged 1 commit into from
Apr 1, 2022

Conversation

ShaMan123
Copy link
Contributor

before

poly._setPositionDimensions() //throws error
poly._setPositionDimensions({}) //ok

now both are ok

@ShaMan123 ShaMan123 requested a review from melchiar April 1, 2022 05:04
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.21 |    76.59 |   86.35 |   82.93 |                                               
 fabric.js |   83.21 |    76.59 |   86.35 |   82.93 | ...,29912,30037,30117-30182,30305,30404,30640 
-----------|---------|----------|---------|---------|-----------------------------------------------

melchiar
melchiar approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@melchiar melchiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure, this is a no brainer.

asturur
asturur previously approved these changes Apr 1, 2022
View reviewed changes
@asturur
Copy link
Member

asturur commented Apr 1, 2022

for things like this with another approval you don't have to wait me, you should be able to merge

@asturur asturur merged commit 41c411d into master Apr 1, 2022
@ShaMan123
Copy link
Contributor Author

for things like this with another approval you don't have to wait me, you should be able to merge

I wasn't here

@ShaMan123 ShaMan123 deleted the minor-poly-safegurad branch April 1, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melchiar melchiar melchiar approved these changes

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShaMan123 @asturur @melchiar